Untitled #1
Closed
Untitled #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le decrements on the same channel).
|
Hi Laurent, the only changes I'm not 100% sure is /* if (byteToRead <= 0) */ { // content-length is not always defined properly by servers If we remove that condition that will means we buffer the entire body in memory, which can cause OOM. So we need to either make it configurable via a property, or explore a better patch. I will work on that asap. Thanks!!!! |
|
First pass, fixed AHC 47 https://github.com/sonatype/async-http-client/compare/33cc6abf52...3d852c7802 |
|
Added support for a new system property to encode space using + instead of %20 |
|
Added support for buffering the response in memory without looking at the content-lenght Just use the JDKAsyncHttpProviderConfig element in order to enable it. |
Closed
slandelle
pushed a commit
that referenced
this pull request
Jul 2, 2014
Merging from original repo on 3/28
hysterus1
added a commit
to hysterus1/async-http-client
that referenced
this pull request
Mar 17, 2021
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi JF,
As mentioned in my email, here are my modifications on AHC. Don't hesitate to send me an email if you want more details.
Laurent